Skip to content

[VarDumper] Fix "Undefined index: argv" when using CliContextProvider #35113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Dec 26, 2019

Q A
Branch? 4.1, 4.2, 4.3, 4.4 or 5.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35084
License MIT

@nicolas-grekas nicolas-grekas changed the title Fixed #35084 [VarDumper] Fix "Undefined index: argv" when using CliContextProvider Dec 26, 2019
@nicolas-grekas nicolas-grekas added this to the 4.3 milestone Dec 26, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 4.3)

@nicolas-grekas nicolas-grekas changed the base branch from master to 4.3 December 28, 2019 14:52
@nicolas-grekas
Copy link
Member

Thank you @xepozz.

nicolas-grekas added a commit that referenced this pull request Dec 28, 2019
…extProvider (xepozz)

This PR was submitted for the master branch but it was merged into the 4.3 branch instead.

Discussion
----------

[VarDumper] Fix "Undefined index: argv" when using CliContextProvider

| Q             | A
| ------------- | ---
| Branch?       | 4.1, 4.2, 4.3, 4.4 or 5.0<!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35084
| License       | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch master.
-->

Commits
-------

340bb14 Fixed #35084
@nicolas-grekas nicolas-grekas merged commit 340bb14 into symfony:4.3 Dec 28, 2019
This was referenced Jan 21, 2020
@xepozz xepozz deleted the fix_35084 branch January 21, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants