[Validator] Add alpha3 option to country constraint #35116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazux
approved these changes
Dec 29, 2019
xabbuh
reviewed
Jan 1, 2020
|
Adding this makes sense to me. We did something similar for the |
|
So in addition we should probably also think about adding the same option to the |
97f8d00 to
c70a24f
Compare
ro0NL
reviewed
Jan 12, 2020
src/Symfony/Component/Validator/Constraints/CountryValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Tests/Constraints/CountryValidatorTest.php
Show resolved
Hide resolved
|
@maxperrimond Do you have time to finish this PR? |
c70a24f to
2703ce3
Compare
|
@fabpot Thank you to remind me about this PR. I push some changes |
fabpot
approved these changes
Jan 31, 2020
2703ce3 to
d6f34a5
Compare
|
Thank you @maxperrimond. |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 9, 2020
…(maxperrimond) This PR was merged into the master branch. Discussion ---------- [Validator] added alpha3 option to country constraint <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Documentation part of symfony/symfony#35116 Commits ------- 912a217 [Validator] added alpha3 option to country constraint
fabpot
added a commit
that referenced
this pull request
Feb 24, 2020
…xabbuh) This PR was merged into the 5.1-dev branch. Discussion ---------- [Validator] add alpha3 option to Language constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #35116 (comment) | License | MIT | Doc PR | Commits ------- ce73b98 add alpha3 option to Language constraint
symfony-splitter
pushed a commit
to symfony/validator
that referenced
this pull request
Feb 24, 2020
…xabbuh) This PR was merged into the 5.1-dev branch. Discussion ---------- [Validator] add alpha3 option to Language constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix symfony/symfony#35116 (comment) | License | MIT | Doc PR | Commits ------- ce73b98e2c add alpha3 option to Language constraint
Merged
|
It might have been discussed somewhere before, but wouldn't a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A following of #33791 and #32988 to add
alpha3option also toCountryconstraint in the validator component.