[Mailer] Make sure you can pass custom headers to Mailgun #35162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, I will. Thank you for a quick reply |
54eafb2 to
dcbb6c5
Compare
|
I fixed other providers and rebased the PRs. @fbourigault Could you review please? |
nicolas-grekas
approved these changes
Jan 4, 2020
dcbb6c5 to
43c1e77
Compare
|
Thank you @Nyholm. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 4, 2020
…(Nyholm) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Mailer] Make sure you can pass custom headers to Mailgun | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | fix #35095 | License | MIT | Doc PR | I can only assume that there was a mistake to use `$header->toString()` since it makes no sense to include the header name here. That is why this is a bugfix and not a new feature. Without this fix my test will fail: ``` Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'{"foo":"bar"}' +'X-Mailgun-Variables: {"foo":"bar"}' ``` There are a few similar places for other mailer bridges that looks like they have similar issues. I dont know those providers very well. I can spend time researching them and confirm if there are bugs there too. But first I want to make sure a fix like this is accepted. Commits ------- 43c1e77 [Mailer] Make sure you can pass custom headers to Mailgun
|
Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can only assume that there was a mistake to use
$header->toString()since it makes no sense to include the header name here. That is why this is a bugfix and not a new feature.Without this fix my test will fail:
There are a few similar places for other mailer bridges that looks like they have similar issues. I dont know those providers very well. I can spend time researching them and confirm if there are bugs there too. But first I want to make sure a fix like this is accepted.