[Notifier] Remove superfluous parameters in *Message::fromNotification() #35167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10b01dd to
24a8f38
Compare
fancyweb
commented
Jan 2, 2020
| @@ -35,7 +35,7 @@ public function __construct(RawMessage $message, Envelope $envelope = null) | |||
| $this->envelope = $envelope; | |||
| } | |||
|
|
|||
| public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self | |||
There was a problem hiding this comment.
Alternative: for the $transport, we could set the transport directly from this method then? But the current code uses the setter everytime.
fancyweb
commented
Jan 2, 2020
| @@ -32,7 +31,7 @@ public function __construct(string $subject, MessageOptionsInterface $options = | |||
| $this->options = $options; | |||
| } | |||
|
|
|||
| public static function fromNotification(Notification $notification, Recipient $recipient, string $transport = null): self | |||
| public static function fromNotification(Notification $notification): self | |||
There was a problem hiding this comment.
Maybe we need $recipient here in the future? But being forced to pass an useless argument is worse in practice for me.
|
There is a failure on deps=low |
24a8f38 to
98d24d9
Compare
fancyweb
commented
Jan 4, 2020
98d24d9 to
e4dec22
Compare
e4dec22 to
d0dacf5
Compare
fabpot
reviewed
Jan 7, 2020
|
@fabpot In this case, shouldn't the methods at least set the passed $transport? I don't understand how keeping any unused argument can be better for usability. Especially the mandatory $recipient on ChatMessage. Could you explain your intention please? Thank you :) |
fabpot
approved these changes
Feb 4, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Feb 4, 2020
…fromNotification() (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [Notifier] Remove superfluous parameters in *Message::fromNotification() | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Those classes are final so I think we don't need those extra arguments. Commits ------- d0dacf5 [Notifier] Remove superfluous parameters in *Message::fromNotification()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those classes are final so I think we don't need those extra arguments.