Skip to content

[Mailer] Payload sent to Sendgrid doesn't include names #35182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

versgui
Copy link

@versgui versgui commented Jan 2, 2020

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

When we use the Sendgrid API to send an email, for fields like to, from, bcc... the endpoint expects to receive an associative array composed of an email address and a optionally a name.

Sendgrid doc extract
https://sendgrid.com/docs/API_Reference/api_v3.html

Symfony sends only the email address, even when the name is provided. I changed the code to allow the bridge to send the name when it's provided.

@versgui versgui changed the base branch from master to 4.3 January 3, 2020 00:44
@versgui versgui changed the base branch from 4.3 to master January 3, 2020 00:44
@versgui
Copy link
Author

versgui commented Jan 3, 2020

Sorry, it seems I didn't pick the good branch. I can redo the request if necessary.

@versgui
Copy link
Author

versgui commented Jan 3, 2020

I redid this PR properly in #35184 . I close this one.

@versgui versgui closed this Jan 3, 2020
@versgui versgui deleted the fix-sendgrid-mailer-payload branch January 3, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants