Skip to content

[Mailer] read default timeout from ini configurations #35194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

[Mailer] read default timeout from ini configurations #35194

merged 1 commit into from
Jan 28, 2020

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Jan 3, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets #35138
License MIT
Doc PR n/a 
MAILER_DSN=mandrill+https://foo@default?timeout=30

@azjezz azjezz force-pushed the mailer-transport-timeout branch from e128abe to 728e9d3 Compare January 3, 2020 13:25
@seddighi78
Copy link

thanks for development

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 4, 2020
@azjezz azjezz force-pushed the mailer-transport-timeout branch 3 times, most recently from a25cb1a to b24b507 Compare January 4, 2020 12:06
@azjezz azjezz force-pushed the mailer-transport-timeout branch from b24b507 to bc3460a Compare January 4, 2020 12:13
@azjezz azjezz force-pushed the mailer-transport-timeout branch from bc3460a to acf2d58 Compare January 4, 2020 12:41
@nicolas-grekas
Copy link
Member

(but a test is failing)

@azjezz
Copy link
Contributor Author

azjezz commented Jan 4, 2020

Fixed 👍

@azjezz azjezz force-pushed the mailer-transport-timeout branch from acf2d58 to 7f88c2d Compare January 4, 2020 13:00
@azjezz azjezz force-pushed the mailer-transport-timeout branch 2 times, most recently from b202024 to c303416 Compare January 5, 2020 14:05
@azjezz azjezz force-pushed the mailer-transport-timeout branch from c303416 to 95292bd Compare January 28, 2020 12:53
@azjezz azjezz changed the title [Mailer] add ability to set socket/http timeout via dsn [Mailer] read default timeout from ini configurations Jan 28, 2020
@azjezz azjezz force-pushed the mailer-transport-timeout branch from 95292bd to dafb057 Compare January 28, 2020 12:53
@fabpot
Copy link
Member

fabpot commented Jan 28, 2020

Thank you @azjezz.

@fabpot fabpot mentioned this pull request Jan 28, 2020
Closed
fabpot added a commit that referenced this pull request Jan 28, 2020
@fabpot
feature #35194 [Mailer] read default timeout from ini configurations …
f0fbdee 
…(azjezz)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Mailer] read default timeout from ini configurations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | #35138
| License       | MIT
| Doc PR        | n/a

```env
MAILER_DSN=mandrill+https://foo@default?timeout=30
```

Commits
-------

dafb057 [Mailer] read default timeout from ini configurations
@fabpot fabpot merged commit dafb057 into symfony:master Jan 28, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@azjezz @seddighi78 @nicolas-grekas @fabpot @carsonbot