[HttpClient] Don't read from the network faster than the CPU can deal with #35223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 6, 2020
| @@ -113,7 +113,7 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| $url = implode('', $url); | |||
|
|
|||
| if (!isset($options['normalized_headers']['user-agent'])) { | |||
| $options['normalized_headers']['user-agent'][] = $options['headers'][] = 'User-Agent: Symfony HttpClient/Curl'; | |||
| $options['headers'][] = 'User-Agent: Symfony HttpClient/Curl'; | |||
There was a problem hiding this comment.
is this change related to this gzip issue ?
There was a problem hiding this comment.
not directly (I spotted this was not required while working on the patch)
nicolas-grekas
added a commit
that referenced
this pull request
Jan 6, 2020
…PU can deal with (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Don't read from the network faster than the CPU can deal with | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Something I spotted while working on #35115: both the curl and native clients don't play well with heavily compressed HTTP streams: they decompress faster than userland can process chunks. The attached patch moves the decompression logic to the chunk generator. This means internally we only deal with raw compressed chunks, and they are decompressed only when passing the value to userland. Commits ------- ac3d77a [HttpClient] Don't read from the network faster than the CPU can deal with
TiGR
reviewed
Jan 7, 2020
| } | ||
|
|
||
| if ('' !== $chunk && null !== $response->content && \strlen($chunk) !== fwrite($response->content, $chunk)) { | ||
| $multi->handlesActivity[$j] = [null, new TransportException('Failed writing %d bytes to the response buffer.', \strlen($chunk))]; |
There was a problem hiding this comment.
@nicolas-grekas I think sprintf is supposed to be here.
There was a problem hiding this comment.
correct :) would you mind sending a PR?
This was referenced Jan 21, 2020
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 22, 2022
This PR was submitted for the 5.4 branch but it was merged into the 6.3 branch instead. Discussion ---------- [HttpClient] Remove unused code | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Not needed since #35223 Commits ------- 5308c7c [HttpClient] Remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I spotted while working on #35115: both the curl and native clients don't play well with heavily compressed HTTP streams: they decompress faster than userland can process chunks.
The attached patch moves the decompression logic to the chunk generator. This means internally we only deal with raw compressed chunks, and they are decompressed only when passing the value to userland.