[Mailer] Fix broken mandrill http send for recipients with names #35227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(please check fabbot failure) |
|
Can you add a test case please? |
fabpot
requested changes
Jan 30, 2020
src/Symfony/Component/Mailer/Bridge/Mailchimp/Http/MandrillTransport.php
Show resolved
Hide resolved
vilius-g
commented
Jan 31, 2020
src/Symfony/Component/Mailer/Bridge/Mailchimp/Http/MandrillTransport.php
Show resolved
Hide resolved
fabpot
approved these changes
Feb 3, 2020
6a3f9bc to
fbfe1ed
Compare
|
Thank you @vilius-g. |
fabpot
added a commit
that referenced
this pull request
Feb 3, 2020
… names (vilius-g) This PR was submitted for the 4.3 branch but it was squashed and merged into the 4.4 branch instead (closes #35227). Discussion ---------- [Mailer] Fix broken mandrill http send for recipients with names | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | As specified in https://mandrillapp.com/api/docs/messages.JSON.html#method=send-raw, Mandrill API expects array of email addresses for `to` parameter. Commits ------- fbfe1ed [Mailer] Fix broken mandrill http send for recipients with names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in https://mandrillapp.com/api/docs/messages.JSON.html#method=send-raw, Mandrill API expects array of email addresses for
toparameter.