Skip to content

[SecurityBundle] Fix collecting traceable listeners info on lazy firewalls #35240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

[SecurityBundle] Fix collecting traceable listeners info on lazy firewalls #35240

merged 1 commit into from
Jan 10, 2020

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jan 7, 2020

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Before:
Screenshot 2020-01-07 at 05 17 47

After:
Screenshot 2020-01-07 at 05 18 12

@chalasr chalasr added this to the 4.4 milestone Jan 7, 2020
@nicolas-grekas
Copy link
Member

I think this breaks laziness of the listeners: LazyFirewallContext won't see $listener instanceof AbstractListener anymore, isn't it?

@chalasr chalasr force-pushed the debug-sec-listeners branch 3 times, most recently from 25ee2ea to 8835188 Compare January 7, 2020 22:05
@chalasr
Copy link
Member Author

chalasr commented Jan 7, 2020

@nicolas-grekas ofc you're right. Should be better now

@chalasr chalasr force-pushed the debug-sec-listeners branch 2 times, most recently from 4af5638 to 6b7d2d3 Compare January 7, 2020 23:02
@chalasr chalasr force-pushed the debug-sec-listeners branch from 6b7d2d3 to a3a9a0e Compare January 9, 2020 21:59
@fabpot
Copy link
Member

fabpot commented Jan 10, 2020

Thank you @chalasr.

fabpot added a commit that referenced this pull request Jan 10, 2020
@fabpot
bug #35240 [SecurityBundle] Fix collecting traceable listeners info o…
d68a4b0 
…n lazy firewalls (chalasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[SecurityBundle] Fix collecting traceable listeners info on lazy firewalls

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Before:
![Screenshot 2020-01-07 at 05 17 47](https://user-images.githubusercontent.com/7502063/71869007-cbffd400-3110-11ea-86ad-234da28621c4.png)

After:
![Screenshot 2020-01-07 at 05 18 12](https://user-images.githubusercontent.com/7502063/71869014-d9b55980-3110-11ea-8efc-1f1b16b2c372.png)

Commits
-------

a3a9a0e [SecurityBundle] Fix collecting traceable listeners info using anonymous: lazy
@fabpot fabpot merged commit a3a9a0e into symfony:4.4 Jan 10, 2020
@chalasr chalasr deleted the debug-sec-listeners branch January 10, 2020 21:28
This was referenced Jan 21, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @nicolas-grekas @fabpot @carsonbot