[HttpClient] fix exception in case of PSR17 discovery failure #35245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, actually the message says This is a mess, sorry :) |
|
Reopening, the message is still better. |
Nyholm
approved these changes
Jan 7, 2020
fabpot
approved these changes
Jan 7, 2020
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jan 7, 2020
…ure (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix exception in case of PSR17 discovery failure | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - On symfony.com, we need to use HTTPlug for 3rd party libs. When `nyholm/psr7` is not installed, we currently see an exception saying `No HTTPlug clients found.` from `HttpClientDiscovery`. This fixes the message by correctly suggesting `nyholm/psr7` instead, since there *is* an HTTPlug client: `HttplugClient` from our HttpClient component. It's quite unfortunate that `guzzle/psr7` provides no PSR17 factory yet, because that would have solved some part of this deps mess. /cc @Nyholm @sagikazarmark FYI Note that https://packagist.org/providers/psr/http-factory-implementation lists `guzzle/psr7` but this is a wrong solution: no tagged release of it is PSR17-compatible, which means installing it doesn't solve the issue. Commits ------- 96e70a4 [HttpClient] fix exception in case of PSR17 discovery failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On symfony.com, we need to use HTTPlug for 3rd party libs. When
nyholm/psr7is not installed, we currently see an exception sayingNo HTTPlug clients found.fromHttpClientDiscovery.This fixes the message by correctly suggesting
nyholm/psr7instead, since there is an HTTPlug client:HttplugClientfrom our HttpClient component.It's quite unfortunate that
guzzle/psr7provides no PSR17 factory yet, because that would have solved some part of this deps mess. /cc @Nyholm @sagikazarmark FYINote that https://packagist.org/providers/psr/http-factory-implementation lists
guzzle/psr7but this is a wrong solution: no tagged release of it is PSR17-compatible, which means installing it doesn't solve the issue.