[PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails #35254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still fox bugs in lower branches so 3.4 might be a fit. |
94ba72a to
6635484
Compare
|
Rebased onto 3.4 |
|
Updated |
| @@ -15,6 +15,13 @@ | |||
|
|
|||
| error_reporting(-1); | |||
|
|
|||
| $passthru_or_fail = function ($command) { | |||
There was a problem hiding this comment.
we use camel case :)
but $passthru would be fine as a name to me
There was a problem hiding this comment.
Will change, but prefer to keep the orFail to make clear there's a difference to plain passthru()
| $passthru_or_fail = function ($command) { | ||
| passthru($command, $return); | ||
| if ($return !== 0) { | ||
| exit(99); |
There was a problem hiding this comment.
if ($return) {
exit($return);
}
| @@ -73,29 +80,29 @@ if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit") || md5_file(__ | |||
| @mkdir($PHPUNIT_DIR, 0777, true); | |||
| chdir($PHPUNIT_DIR); | |||
| if (file_exists("phpunit-$PHPUNIT_VERSION")) { | |||
| passthru(sprintf('\\' === DIRECTORY_SEPARATOR ? 'rmdir /S /Q %s > NUL': 'rm -rf %s', "phpunit-$PHPUNIT_VERSION.old")); | |||
| $passthru_or_fail(sprintf('\\' === DIRECTORY_SEPARATOR ? 'rmdir /S /Q %s > NUL': 'rm -rf %s', "phpunit-$PHPUNIT_VERSION.old")); | |||
There was a problem hiding this comment.
this can and should fail silently by design, isn't it?
There was a problem hiding this comment.
What is it trying to do here at all?
remove the -.old version if it is there, then rename phpunit-$VERSION to phpunit-$VERSION.old, and then try removing that again?
Doesn't that effectively remove both the .old and current one?
| rename("phpunit-$PHPUNIT_VERSION", "phpunit-$PHPUNIT_VERSION.old"); | ||
| passthru(sprintf('\\' === DIRECTORY_SEPARATOR ? 'rmdir /S /Q %s': 'rm -rf %s', "phpunit-$PHPUNIT_VERSION.old")); | ||
| $passthru_or_fail(sprintf('\\' === DIRECTORY_SEPARATOR ? 'rmdir /S /Q %s': 'rm -rf %s', "phpunit-$PHPUNIT_VERSION.old")); |
fbbb23d to
576e185
Compare
|
Thank you @mpdude. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 9, 2020
… passthru() commands fails (mpdude) This PR was squashed before being merged into the 3.4 branch. Discussion ---------- [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Some commands executed by the `simple-phpunit` script are not checked for success. For example [here](https://travis-ci.org/twigphp/Twig/jobs/634110681), Composer fails with the message ``` [InvalidArgumentException] Could not find package phpunit/phpunit with version 7.5.* in a version inst allable using your PHP version 7.0.25. ``` Yet, the `simple-phpunit` script happily continues, going over failing `chdir()`, `file_get_contents()` and `include()` calls and eventually returns a successful `0` exit code. So CI tests look OK when in fact PHPUnit was not even downloaded. Commits ------- 576e185 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commands executed by the
simple-phpunitscript are not checked for success. For example here, Composer fails with the messageYet, the
simple-phpunitscript happily continues, going over failingchdir(),file_get_contents()andinclude()calls and eventually returns a successful0exit code. So CI tests look OK when in fact PHPUnit was not even downloaded.