[EventDispatcher] fix empty prio #35260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we update the contract then? Or just the wrongful calling sides? |
|
@ro0NL thx, good point, pushed changes |
|
This looks suspicious to me. It looks like a BC break. |
xabbuh
requested changes
Jan 9, 2020
| @@ -94,7 +94,7 @@ public function getListeners(string $eventName = null) | |||
| public function getListenerPriority(string $eventName, $listener) | |||
| { | |||
| if (empty($this->listeners[$eventName])) { | |||
| return null; | |||
| return 0; | |||
There was a problem hiding this comment.
This looks wrong to me. The interface states this:
Returns null if the event or the listener does not exist.
Making this change here violates the contract defined by the interface.
| @@ -114,7 +114,7 @@ public function getListenerPriority(string $eventName, $listener) | |||
| } | |||
| } | |||
|
|
|||
| return null; | |||
| return 0; | |||
| @@ -62,7 +62,7 @@ public function getListeners(string $eventName = null); | |||
| * | |||
| * @param callable $listener The listener | |||
| * | |||
| * @return int|null The event listener priority | |||
| * @return int The event listener priority, defaults to 0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returns
0instead ofnullas it is typ hinted on other places anyway, and leads to exceptions sometimes.