[Routing] Fix using a custom matcher & generator dumper class #35261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I applied the same patch logic on the matcher btw because looking at the code, I guess it suffers the same problem. |
nicolas-grekas
approved these changes
Jan 8, 2020
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 8, 2020
…ass (fancyweb) This PR was merged into the 4.3 branch. Discussion ---------- [Routing] Fix using a custom matcher & generator dumper class | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR fixes a BC break I encountered while upgrading an existing project from 4.2 to 4.4. In this project I use a custom `generator_dumper_class` that is not a `CompiledUrlGeneratorDumper` (it didn't exist yet). I faced 2 problems: - The generator is considered "compiled" while it is not. This is because we don't check if the `generator_dumper_class` is effectively a `CompiledUrlGeneratorDumper` to compute the `$compiled` variable. That result in a `\TypeError: Return value of Symfony\Component\Routing\Router::getCompiledRoutes() must be of the type array, int returned` - My custom dumper is not used at all. This is because of #31964. I altered the condition to fall back only in one way and not the other. The original issue is still fixed (if one uses a classic `UrlGenerator` + a `CompiledUrlGeneratorDumper`, it fall backs on `PhpGeneratorDumper`). However, if one uses a `CompiledUrlGenerator` + a classic `PhpGeneratorDumper` (my case), the classic dumper is still returned. Since `$compiled` is now correctly computed, this case works fine. The Router won't try to get the compiled routes and will use the "old" way. Commits ------- 3a840a9 [Routing] Fix using a custom matcher & generator dumper class
This was referenced Jan 21, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a BC break I encountered while upgrading an existing project from 4.2 to 4.4. In this project I use a custom
generator_dumper_classthat is not aCompiledUrlGeneratorDumper(it didn't exist yet). I faced 2 problems:generator_dumper_classis effectively aCompiledUrlGeneratorDumperto compute the$compiledvariable. That result in a\TypeError: Return value of Symfony\Component\Routing\Router::getCompiledRoutes() must be of the type array, int returnedUrlGenerator+ aCompiledUrlGeneratorDumper, it fall backs onPhpGeneratorDumper). However, if one uses aCompiledUrlGenerator+ a classicPhpGeneratorDumper(my case), the classic dumper is still returned. Since$compiledis now correctly computed, this case works fine. The Router won't try to get the compiled routes and will use the "old" way.