-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Configure RequestContext through router config #35281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fabpot
merged 1 commit into
symfony:master
from
benji07:feature/router-request-ctx-config
Jan 10, 2020
Merged
[FrameworkBundle] Configure RequestContext through router config #35281
fabpot
merged 1 commit into
symfony:master
from
benji07:feature/router-request-ctx-config
Jan 10, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benji07
commented
Jan 9, 2020
•
edited
Loading
edited
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
Deprecations? | no |
Tickets | Fix #35229 |
License | MIT |
Doc PR | symfony/symfony-docs#... |
- PR on symfony/symfony-docs
bdb0b52
to
f98d2bf
Compare
fancyweb
reviewed
Jan 9, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
ogizanagi
reviewed
Jan 9, 2020
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
f98d2bf
to
427852f
Compare
ogizanagi
reviewed
Jan 9, 2020
src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml
Outdated
Show resolved
Hide resolved
427852f
to
6658900
Compare
ogizanagi
approved these changes
Jan 10, 2020
fabpot
approved these changes
Jan 10, 2020
Thank you @benji07. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
…ter config (benji07) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] Configure RequestContext through router config | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #35229 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch master. --> - [ ] PR on symfony/symfony-docs Commits ------- 6658900 [FrameworkBundle] Configure RequestContext through router config
This was referenced Jan 10, 2020
fabpot
added a commit
that referenced
this pull request
Jan 11, 2020
…er.context (ogizanagi) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] Add missing entry about framework.router.context | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Relates to #35281 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A Some minor tweaks about #35281 Commits ------- 5a83b07 [FrameworkBundle] Add missing entry about framework.router.context
fabpot
added a commit
that referenced
this pull request
May 4, 2020
…RI with a DSN (nicolas-grekas) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] Allow configuring the default base URI with a DSN | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fixes #35121, replaces #35580, partially reverts #35281 | License | MIT | Doc PR | - Instead of defining 3-4 parameters, this PR enables using a single DSN to configure the default URL context (for commands mainly): ``` framework: router: base_uri: 'https://my.host:8443/base-path/' ``` When using parameters directly, one can now set the same absolute URI in the `router.request_context.base_url` parameter, this will provide the same benefit. Commits ------- 250fa7e [FrameworkBundle] Allow configuring the default base URI with a DSN
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.