[Filesystem][FilesystemCommonTrait] Use a dedicated directory when there are no namespace #35290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere are no namespace
e3ee073 to
eaa767b
Compare
nicolas-grekas
approved these changes
Jan 9, 2020
fabpot
approved these changes
Jan 10, 2020
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
…ory when there are no namespace (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [Filesystem][FilesystemCommonTrait] Use a dedicated directory when there are no namespace | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR fixes the following edge case: - you use a namespaced filesystem adapter with root dir `/foo` and namespace `a`: all files are written in `/foo/a` (eg: it will write `/foo/a/b/file`) - you use another filesystem adapter with the same root dir but without namespace and you clear it. - it will fail because it will try to delete the `/foo/a/b` directory (see #33921 new `scanHashDir()` method - `a` is a possible dir value (see `getFile()`) so we look for it). The simple solution (suggested by @nicolas-grekas) is to put the "empty namespace" in a dedicated directory. Bonus: that will fix the tests that currently always fail on AppVeyor. The file in the namespace `a` is a leftover from a previous test. Without this patch, I have the same fail on my Mac. I did not look why it currently passes on travis. Commits ------- eaa767b [Filesystem][FilesystemCommonTrait] Use a dedicated directory when there are no namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following edge case:
/fooand namespacea: all files are written in/foo/a(eg: it will write/foo/a/I/W/file)/foo/a/Idirectory (see [Cache] improve perf of pruning for fs-based adapters #33921 newscanHashDir()method -ais a possible dir value (seegetFile()) so we look for it).The simple solution (suggested by @nicolas-grekas) is to put the "empty namespace" in a dedicated directory.
Bonus: that will fix the tests that currently always fail on AppVeyor. The file in the namespace
ais a leftover from a previous test. Without this patch, I have the same fail on my Mac. I did not look why it currently passes on travis.