Avoid stale-if-error in FrameworkBundle's HttpCache if kernel.debug = true
#35299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jan 10, 2020
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Jan 10, 2020
…ernel.debug = true (mpdude) This PR was merged into the 3.4 branch. Discussion ---------- Avoid `stale-if-error` in FrameworkBundle's HttpCache if kernel.debug = true | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #24248 (maybe?) | License | MIT | Doc PR | When working with the `HttpCache` in development, error messages may not become visible if a `public` response has been successfully generated for the same URL before. This is because the `HttpCache` from the `HttpKernel` component by default sets `stale_if_error` to 60 seconds. At least when using the `HttpCache` subclass from the `FrameworkBundle`, we know about the `kernel.debug` setting and its intention to support local development. In that case, we could set the *default* `stale-if-error` value to 0. Commits ------- 3a23ec8 Avoid stale-if-error if kernel.debug = true, because it hides errors
This was referenced Jan 21, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the
HttpCachein development, error messages may not become visible if apublicresponse has been successfully generated for the same URL before.This is because the
HttpCachefrom theHttpKernelcomponent by default setsstale_if_errorto 60 seconds.At least when using the
HttpCachesubclass from theFrameworkBundle, we know about thekernel.debugsetting and its intention to support local development. In that case, we could set the defaultstale-if-errorvalue to 0.