[HttpClient][WDT] Add missing response content #35317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Unfortunately, fetching the response content breaks laziness of responses.
The correct approach is not easy to implement as it requires buffering the content while it is yield - and there is little extension point to do this easily.
I'd suggest closing here, as #33311 already exists to keep track of the need for this.
| // Try to convert response to array if possible | ||
| try { | ||
| $responseContent = $response->toArray(false); | ||
| } catch (\Throwable $e) { |
There was a problem hiding this comment.
never ever do this: catch throwable and silence any errors
check https://twitter.com/nikita_ppv/status/1042676176836341760 also
There was a problem hiding this comment.
Thanks for explain with catching.
|
So I closing in favor of #33311 and breaking laziness. |
|
See #35407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataCollector for HttpClient was added in #33015 but missing important (IMHO) thing during profiling a request to endpoint.
The PR add information about content do we get.