[Security] Fix RememberMe with null password #35335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this cause any issue? We're not using string mode, so it shouldn't, isn't it? Beside this, IF there is an issue, the same code exists on 3.4 :) |
|
Yes it triggers: It's not an issue before 5.0 because method |
|
Oh, ok. Then we need to change the docblock on 3.4+, and make this nullable on 5.0. That's the most sensible option to me, from an historical perspective, don't you think? |
c713200 to
a7d0d82
Compare
nicolas-grekas
approved these changes
Jan 14, 2020
chalasr
added a commit
that referenced
this pull request
Jan 16, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [Security] Fix RememberMe with null password | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | NA | License | MIT | Doc PR | NA From `UserInterface` the method getPassword may return null, while generateCookieHash requires a string. This PR changes the signature of the methods to allows null password Similar to #35335 for branch 3.4 Commits ------- 820eb35 Fix RememberMe with null password
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 20, 2020
This PR was merged into the 5.0 branch. Discussion ---------- [Security] Fix RememberMe with null password | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | yes | New feature? | no | Deprecations? | yes | Tickets | NA | License | MIT | Doc PR | NA From `UserInterface` the method getPassword may return null, while generateCookieHash requires a string. This PR changes the signature of the methods to allows null password Commits ------- a7d0d82 Fix RememberMe with null password
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
UserInterfacethe method getPassword may return null, while generateCookieHash requires a string.This PR changes the signature of the methods to allows null password