Skip to content

[String] add missing encoding when calling mb_ord() #35339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2020
Merged

[String] add missing encoding when calling mb_ord() #35339

merged 1 commit into from
Jan 20, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Jan 14, 2020
OskarStark
OskarStark reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a test? Looks like it was not tested before?

@nicolas-grekas
Copy link
Member Author

I don't think we need to test this.

nicolas-grekas added a commit that referenced this pull request Jan 20, 2020
@nicolas-grekas
bug #35339 [String] add missing encoding when calling mb_ord() (nicol…
0dcf2fc 
…as-grekas)

This PR was merged into the 5.0 branch.

Discussion
----------

[String] add missing encoding when calling mb_ord()

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

759e20e [String] add missing encoding when calling mb_ord()
@nicolas-grekas nicolas-grekas merged commit 759e20e into symfony:5.0 Jan 20, 2020
@fabpot fabpot mentioned this pull request Jan 21, 2020
Merged
@nicolas-grekas nicolas-grekas deleted the mb-ord branch January 22, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @OskarStark @fancyweb @carsonbot