[WebProfilerBundle][HttpClient] Added profiler links in the Web Profiler -> Http Client panel #35391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 . Thanks for implementing it. I was wondering though. This solutions works only if the profiler token is on the same url. Why not pointing out to the link provided by the header ? (in a new tab maybe ?) |
|
Yeah, good idea, I will update the implementation and use the x-debug-token-link header instead. |
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig
Outdated
Show resolved
Hide resolved
|
Thank you for the feedback @Neirda24 and @nicolas-grekas. I have made the changes. |
nicolas-grekas
approved these changes
Jan 21, 2020
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/http_client.html.twig
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jan 22, 2020
…ler -> Http Client panel
|
Thank you @cristagu. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @Neirda24's idea in this comment, I parsed the response headers collected by the TraceableHttpClient and created profiler links in the HttpClient Web Profiler panel for all the requests having the 'X-Debug-Token' header.