[DoctrineBridge] [DX] Improve condition for exception text in ManagerRegistry to avoid confusion #35396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
released v3.4.37
This PR was merged into the 3.4 branch. Discussion ---------- Fix testing with mongodb | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- 28cd964 Fix testing with mongodb
* 3.4: Fix testing with mongodb bumped Symfony version to 3.4.38 updated VERSION for 3.4.37 update CONTRIBUTORS for 3.4.37 updated CHANGELOG for 3.4.37
nicolas-grekas
approved these changes
Jan 23, 2020
…Registry to avoid confusion
|
Thank you @guilliamxavier. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2020
…xt in ManagerRegistry to avoid confusion (guilliamxavier) This PR was submitted for the 4.4 branch but it was merged into the 4.3 branch instead. Discussion ---------- [DoctrineBridge] [DX] Improve condition for exception text in ManagerRegistry to avoid confusion | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yesish | New feature? | no | Deprecations? | no | Tickets | Fix #31047 (comment) | License | MIT | Doc PR | - (Targetting 4.4 because 4.3 is already almost EOM) Commits ------- 0d47fdf [DoctrineBridge] [DX] Improve condition for exception text in ManagerRegistry to avoid confusion
|
Thank you and sorry for the extra work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Targetting 4.4 because 4.3 is already almost EOM)