Skip to content

[Console] Set Command::setHidden() final for adding default param in SF 6.0 #35402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

[Console] Set Command::setHidden() final for adding default param in SF 6.0 #35402

merged 1 commit into from
Jan 27, 2020

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 20, 2020

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

@nicolas-grekas
Copy link
Member

Would be nice, but that's a BC break... :)

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 20, 2020
@nicolas-grekas
Copy link
Member

Could be made @final since Symfony 5.1 to unlock the change for 6.0 (requires proper notes in the changelog+upgrade files of course)

@lyrixx
Copy link
Member Author

lyrixx commented Jan 21, 2020

OK, Fixed

@lyrixx lyrixx changed the title [Console] Add default parameter (true) for Command::setHidden() [Console] Set Command::setHidden() final for adding default param in SF 6.0 Jan 21, 2020
fabpot
fabpot requested changes Jan 22, 2020
View reviewed changes
@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

nicolas-grekas added a commit that referenced this pull request Jan 27, 2020
@nicolas-grekas
feature #35402 [Console] Set Command::setHidden() final for adding de…
5182135 
…fault param in SF 6.0 (lyrixx)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Console] Set Command::setHidden() final for adding default param in SF 6.0

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

e2ede07 [Console] Add default parameter (true) for Command::setHidden()
@nicolas-grekas nicolas-grekas merged commit e2ede07 into symfony:master Jan 27, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Jan 27, 2020
Closed
@lyrixx lyrixx deleted the console-hidden branch January 27, 2020 12:23
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lyrixx @nicolas-grekas @fabpot @chalasr @carsonbot