Skip to content

[HttpClient] collect the body of responses when possible #35407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

[HttpClient] collect the body of responses when possible #35407

merged 1 commit into from
Jan 22, 2020

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 20, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets Part of #33311
License MIT
Doc PR -

This is missing one thing: the HTML part in the profiler.

image

image

@nicolas-grekas nicolas-grekas added this to the next milestone Jan 20, 2020
This was referenced Jan 20, 2020
Closed
Closed
@fabpot
Copy link
Member

fabpot commented Jan 22, 2020

Thank you @nicolas-grekas.

@fabpot fabpot mentioned this pull request Jan 22, 2020
Closed
fabpot added a commit that referenced this pull request Jan 22, 2020
@fabpot
feature #35407 [HttpClient] collect the body of responses when possib…
07818f2 
…le (nicolas-grekas)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpClient] collect the body of responses when possible

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Part of #33311
| License       | MIT
| Doc PR        | -

This is missing one thing: the HTML part in the profiler.

![image](https://user-images.githubusercontent.com/243674/72798816-29813e00-3c44-11ea-9586-99c2c6b91640.png)

![image](https://user-images.githubusercontent.com/243674/72798851-3f8efe80-3c44-11ea-973b-7ecc64a5a542.png)

Commits
-------

121f728 [HttpClient] collect the body of responses when possible
@fabpot fabpot merged commit 121f728 into symfony:master Jan 22, 2020
@nicolas-grekas nicolas-grekas deleted the hc-trace branch January 22, 2020 07:07
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 2, 2020
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@ankahla ankahla mentioned this pull request Oct 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature HttpClient Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @fabpot @carsonbot