Skip to content

[Messenger] Add missing documentation link in README #35409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2020
Merged

[Messenger] Add missing documentation link in README #35409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80a7ad
[HttpKernel] restore compat with clock mocking
nicolas-grekas Jan 21, 2020
5714eaa
Add link to messenger documentation in its README
pyrech Jan 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Symfony/Component/HttpKernel/Tests/EventListener/DisallowRobotsIndexingListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ class DisallowRobotsIndexingListenerTest extends TestCase
/**
* @dataProvider provideResponses
*/
public function testInvoke(?string $expected, Response $response): void
public function testInvoke(?string $expected, array $responseArgs)
{
$response = new Response(...$responseArgs);
$listener = new DisallowRobotsIndexingListener();

$event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $this->createMock(Request::class), KernelInterface::MASTER_REQUEST, $response);
Expand All @@ -37,11 +38,11 @@ public function testInvoke(?string $expected, Response $response): void

public function provideResponses(): iterable
{
yield 'No header' => ['noindex', new Response()];
yield 'No header' => ['noindex', []];

yield 'Header already set' => [
'something else',
new Response('', 204, ['X-Robots-Tag' => 'something else']),
['', 204, ['X-Robots-Tag' => 'something else']],
];
}
}
1 change: 1 addition & 0 deletions src/Symfony/Component/Messenger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ are not covered by Symfony's
Resources
---------

* [Documentation](https://symfony.com/doc/current/components/messenger.html)
* [Contributing](https://symfony.com/doc/current/contributing/index.html)
* [Report issues](https://github.com/symfony/symfony/issues) and
[send Pull Requests](https://github.com/symfony/symfony/pulls)
Expand Down