[CssSelector] Added cache on top of CssSelectorConverter #35425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lyrixx
commented
Jan 21, 2020
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
d905643 to
5f357e3
Compare
OskarStark
reviewed
Jan 21, 2020
|
should we use 2 static properties for the cache, or an instance property ? |
|
Also, the code may be simpler if we define an instance-level |
|
A New crawler is instanced on each method call (for the results). Then each time you call filter() a new css selector converter is instansiated. That's why the cache is static I will implement your last idea 👍 |
edec12f to
bdc121c
Compare
nicolas-grekas
approved these changes
Jan 27, 2020
fabpot
approved these changes
Jan 27, 2020
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Jan 27, 2020
…er (lyrixx) This PR was merged into the 5.1-dev branch. Discussion ---------- [CssSelector] Added cache on top of CssSelectorConverter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- ed11d52 [CssSelector] Added cache on top of CssSelectorConverter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.