[Workflow] Added parameter type hinting where possible. #35434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think so. Thanks @fre5h for your PR but Most of your change break the BC promise refs: |
|
About the I'm sorry, But I'm gonna close your PR because It cannot be merged. |
|
@lyrixx so we missed those because they break BC :) i see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #32223 were added type hintings in most classes, but not in all possible. I tried to add more type hintings. Most of my changes look reasonable, but I am not sure in every.
If you find, that in some class/method type hintings are not welcome, then notice it and I will remove it.
If you find, that all my changes are senseless, then just close this pull request :)