Skip to content

Conversation

jderusse
Copy link
Member

Q A
Branch? 4.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Connection::DEFAULT_OPTIONS is an key/value array. The exception Unknown option found : [%s]. Allowed options are [%s] should use allowed option's key instead of the value.

@chalasr chalasr added this to the 4.3 milestone Jan 27, 2020
@chalasr
Copy link
Member

chalasr commented Jan 27, 2020

Thank you @jderusse.

chalasr pushed a commit that referenced this pull request Jan 27, 2020
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Fix messenger argument

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

`Connection::DEFAULT_OPTIONS` is an key/value array. The exception `Unknown option found : [%s]. Allowed options are [%s]` should use allowed option's key instead of the value.

Commits
-------

ae0c634 Fix exception message in Doctrine Messenger
@chalasr chalasr merged commit ae0c634 into symfony:4.3 Jan 27, 2020
@jderusse jderusse deleted the fix-messenger-argument branch March 5, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants