[Messenger] Add TLS option to Redis transport's DSN #35503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jan 29, 2020
stof
reviewed
Jan 29, 2020
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Jan 29, 2020
f2a63c1 to
09ec907
Compare
|
Thank you @Nyholm. |
|
Thank you for merging. |
Merged
This was referenced Dec 22, 2020
nicolas-grekas
added a commit
that referenced
this pull request
Feb 22, 2021
… (misaert) This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead. Discussion ---------- [Cache] Fix Redis TLS scheme `rediss` for Redis connection | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#14728 Like #35503 on Symfony Messenger, this will enable TLS support for Redis adapter. The implementation just prefix the host with `tls://` as described here: https://github.com/phpredis/phpredis#connect-open I don't know how to test it because I guess I need a TLS Redis in `src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php`. Commits ------- 3288897 [Cache] Fix Redis TLS scheme `rediss` for Redis connection
nicolas-grekas
added a commit
that referenced
this pull request
Feb 26, 2021
… to Redis transport (njutn95) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Messenger] Add `rediss://` DSN scheme support for TLS to Redis transport | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | | License | MIT | Doc PR | This adds a support for `rediss://` DSN (as discussed in #39599) and deprecates the use of `tls` parameter introduced in #35503 so it can be standardized to single format. Commits ------- 28e7b74 [Messenger] Add `rediss://` DSN scheme support for TLS to Redis transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @matas-valuzis, this will enable TLS support for Redis transport.
Configure it with the following DSN
The implementation just prefix the host with
tls://as described here: https://github.com/phpredis/phpredis#connect-openIt is already possible to use TLS with the Redis transport, but there are not support in the DSN until now.