[FrameworkBundle] Use MailerAssertionsTrait in KernelTestCase #35534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 4, 2020
|
Thank you @adrienfr. |
fabpot
added a commit
that referenced
this pull request
Feb 4, 2020
…estCase (adrienfr) This PR was merged into the 5.1-dev branch. Discussion ---------- [FrameworkBundle] Use MailerAssertionsTrait in KernelTestCase | Q | A | ------------- | --- | Branch? | 4.4+ | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #35510 | License | MIT | Doc PR | Since 4.4, we have new PHPUnit constraints for the mailer component, but these are only available with `WebTestCase` and not `KernelTestCase`. I think this would be useful to access these constraints from both TestCase. I don't know if I should move these [tests](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/MailerTest.php) or add new ones only for `KernelTestCase`? Commits ------- 1b1ab29 [FrameworkBundle] Use MailerAssertionsTrait in KernelTestCase
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4.4, we have new PHPUnit constraints for the mailer component, but these are only available with
WebTestCaseand notKernelTestCase. I think this would be useful to access these constraints from both TestCase.I don't know if I should move these tests or add new ones only for
KernelTestCase?