[Console][QuestionHelper] Use String width() to properly move the cursor backwards #35536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think its better to extract the behavior we are currently using in the string component. Its quite hard to say the bug is only fixed by a component which is not available all the time. I think its worth, cause we fix 3.4 and 4.4. In 5.0 we should definitely use the String component then |
|
I agree with Oskar here. The combination of symfony/console:3.4 and symfony/string is very unlikely to happen also. Let's copy paste the unicode logic in Console up to the 5.0 branch. |
|
We cannot copy/paste from String, that's a whole set of maps and logic there. We should consider this issue unfixable in 3.4/4.4 and use String in master IMHO. |
|
Closing as this won't happen on 3.4. |
fabpot
added a commit
that referenced
this pull request
Feb 11, 2020
…ove the cursor backwards (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [Console][QuestionHelper] Use String width() to properly move the cursor backwards | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #35536 (comment) | License | MIT | Doc PR | - This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed. Commits ------- 67a1f55 [Console][QuestionHelper] Use String width() to properly move the cursor backwards
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Feb 11, 2020
…ove the cursor backwards (fancyweb) This PR was merged into the 5.1-dev branch. Discussion ---------- [Console][QuestionHelper] Use String width() to properly move the cursor backwards | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | symfony/symfony#35536 (comment) | License | MIT | Doc PR | - This bug can only be fixed on master since we need to require the String component. Once the component is required, we can iterate in the Console component to use it more where it is needed. Commits ------- 67a1f55ce1 [Console][QuestionHelper] Use String width() to properly move the cursor backwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a bug fix on 3.4 if the String component is installed. On 5.0, we can add a test with symfony/string as a dev dependency.