[String] Add the s() helper method #35625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09f34d3 to
401500f
Compare
nicolas-grekas
approved these changes
Feb 6, 2020
yceruto
approved these changes
Feb 6, 2020
401500f to
a277037
Compare
a277037 to
659cdf1
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 7, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [String] Add the s() helper method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #35578 (comment) | License | MIT | Doc PR | - This method will be useful in our code base, and to anyone that doesn't really understand the differences between UnicodeString and ByteString. Commits ------- 659cdf1 [String] Add the s() helper method
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method will be useful in our code base, and to anyone that doesn't really understand the differences between UnicodeString and ByteString.