[Routing] Add locale requirement for localized routes #35692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
reviewed
Feb 13, 2020
There was a problem hiding this comment.
I would make this strictness opt-in, with a strict_i18n option defaulting to false for BC.
We should then trigger a deprecation that can be implemented in this PR, to default to true in Symfony 6.
If it happens that there are use cases for false within two years we can keep the option, otherwise deprecate it in 6.1 to remove it in 7.0.
1c269ae to
8b3e8d0
Compare
|
I'd prefer no options for this. Options increase complexity a lot. |
8b3e8d0 to
1520c4a
Compare
|
Should target 4.4 I'd say. |
I agree, but this implementation is based on Should I create another PR ? |
|
Yes please |
Co-authored-by: Mathias Arlaud <mathias.arlaud@gmail.com> Co-authored-by: Ahmed Tailouloute <ahmed.tailouloute@gmail.com>
1520c4a to
5e3f9d8
Compare
nicolas-grekas
approved these changes
Feb 19, 2020
|
Closing in favor of #35735 actually. |
fabpot
added a commit
that referenced
this pull request
Feb 20, 2020
…rld) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Add locale requirement for localized routes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT 4.4 version of #35692 If you're using localized routes, you expect to have these kind of routes available: - `/fr/accueil` - `/en/home` But nowadays, these routes are unexpectedly available: - `/en/accueil` - `/fr/home` When importing routes like that: - `prefix: "/{_locale}"` - `@Route({"en": "/home", "fr": "/accueil"}, name="home")` This PR proposes to add a strict locale requirement for localized so that the above routes won't be available. Commits ------- 50d7445 [Routing] Add locale requirement for localized routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're using localized routes, you expect to have these kind of routes available:
/fr/accueil/en/homeBut nowadays, these routes are unexpectedly available:
/en/accueil/fr/homeThis PR proposes to add a strict locale requirement for localized so that the above routes won't be available.