Skip to content

[Routing] Add stateless route attribute #35782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 29, 2020
Merged

[Routing] Add stateless route attribute #35782

merged 1 commit into from
Feb 29, 2020

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Feb 19, 2020 •
edited by nicolas-grekas
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Ticket https://github.com/orgs/symfony/projects/1#card-30506005
License MIT
Doc PR TODO

On top of #35732

Add a stateless attribute for:
Routes in annotations

@Route(stateless=true)

Yaml

route:
  stateless: true

Xml

<route stateless="true" />

PHP configurator

$route->stateless(true);

That stateless attribute is a shortcut for setting _stateless default attribute in route.

@mtarld mtarld force-pushed the feature/stateless-attribute branch from 0b2dda8 to e63e222 Compare February 20, 2020 08:14
@nicolas-grekas nicolas-grekas added this to the next milestone Feb 20, 2020
@mtarld mtarld force-pushed the feature/stateless-attribute branch 2 times, most recently from 21db0f2 to 484f721 Compare February 26, 2020 10:56
@mtarld mtarld marked this pull request as ready for review February 26, 2020 11:05
nicolas-grekas
nicolas-grekas approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor thing.

@mtarld mtarld force-pushed the feature/stateless-attribute branch from 484f721 to 2da68ba Compare February 26, 2020 14:20
@fabpot
Copy link
Member

fabpot commented Feb 29, 2020

Thank you @mtarld.

@fabpot fabpot mentioned this pull request Feb 29, 2020
Closed
@fabpot fabpot merged commit 146945a into symfony:master Feb 29, 2020
@mtarld mtarld deleted the feature/stateless-attribute branch February 29, 2020 11:03
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Routing Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@mtarld @fabpot @nicolas-grekas @carsonbot