Skip to content

Use strict assertSame instead of assertEquals in Asset component tests #35793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

Use strict assertSame instead of assertEquals in Asset component tests #35793

merged 1 commit into from
Feb 20, 2020

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Feb 19, 2020 •
edited
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? no
Deprecations? no
Tickets #35762 (comment)
License MIT
Doc PR N/A

Using assertSame instead of assertEquals is recommended when possible (see sebastianbergmann/phpunit-documentation-english#3). It is stricter and must be more efficient (=== vs a comparator class).

Also, removing useless string cast.

@GromNaN GromNaN mentioned this pull request Feb 19, 2020
Merged
@GromNaN GromNaN requested a review from Tobion February 20, 2020 08:21
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Feb 20, 2020
@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit 7b1e4ea into symfony:3.4 Feb 20, 2020
@GromNaN GromNaN deleted the fix/3.4/test-style branch February 20, 2020 14:20
@mhujer mhujer mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Awaiting requested review from Tobion

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@GromNaN @nicolas-grekas @Tobion @carsonbot