[HttpClient][DX] Add URL context to JsonException messages #35822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b7c0cf to
2f61d87
Compare
|
I saw that you asked for this on Slack: improving the message of an exception is ... an improvement :) As such, this should target master. |
2f61d87 to
0653917
Compare
|
Thank you @GromNaN. |
|
Thank you @nicolas-grekas for finishing the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help when debugging incorrect JSON responses, this PR adds the requested URL to the error message.
Before:
Syntax ErrorAfter:
Syntax error, for "https://example.com/file.json".See the 2nd commit for full diff in new unit tests