[BrowserKit] Nested file array prevents uploading file #35827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what's wrong with thew CI system. Appveyor reports an error despite having all checks green. fabpot.io reports CS issues. I went and fixed CS issues in preexisting code as per the CONTRIBUTING.md docs, and now fabpot.io reports reports one more issue than previously. I have no idea what I'm expected to do here to pass the build. The rules are obfuscated and this bug is going to affect my workshop on Monday. |
3c2dc58 to
dae8f18
Compare
dae8f18 to
e15f05e
Compare
nicolas-grekas
approved these changes
Feb 23, 2020
There was a problem hiding this comment.
Thank you @afilina.
I rebased your PR to target 4.4 + fixed some minor CS issues meanwhile.
chalasr
approved these changes
Feb 23, 2020
|
Thank you @afilina. |
fabpot
added a commit
that referenced
this pull request
Mar 28, 2020
… uploads (codebay) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [BrowserKit] fixed missing post request parameters in file uploads | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Pull Request #35827 "[BrowserKit] Nested file array prevents uploading file" introduced a bug that had not been previously covered by unit tests for the component. Requests that include additional parameters with a file upload are not being included Commits ------- 7abee62 [BrowserKit] fixed missing post request parameters in file uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HttpBrowser doesn't play nicely with Symfony\Component\DomCrawler::getPhpFiles().
The former assumes a flat array structure, while the latter explicitly un-flattens it, causing files to silently get ignored by the DomCrawler's submitForm.