[Notifier] Add unit tests #35847
Merged
[Notifier] Add unit tests #35847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ee32aa to
ad284de
Compare
src/Symfony/Component/Notifier/Tests/Channel/AbstractChannelTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Notifier/Tests/Channel/AbstractChannelTest.php
Outdated
Show resolved
Hide resolved
I would like to add tests for the If you are fine with only merging What do you think? |
|
Yes please: tests that run on 5.0 should be submitted there. Then tests for new notifiers should go on master. |
3444d60 to
af0d162
Compare
af0d162 to
022c170
Compare
|
(failures unrelated, needs review) |
fabpot
approved these changes
Mar 16, 2020
|
Thank you @jschaedl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractChannelChannelPolicyRecipientTest(done in PR [Notifier] Change notifier recipient handling #35773)EmailRecipientTest(done in PR [Notifier] Change notifier recipient handling #35773)SmsRecipientTest(done in PR [Notifier] Change notifier recipient handling #35773)Transports(see PR [Notifier] Remove default transport property in Transports class #35834)