Skip to content

[VarDumper] improve rendering HTML #35959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2020
Merged

[VarDumper] improve rendering HTML #35959

merged 1 commit into from
Jun 30, 2020

Conversation

ln-dim
Copy link
Contributor

@ln-dim ln-dim commented Mar 4, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #35800
License MIT
Doc PR -

I improved the rendering so that HtmlDumper makes a decision on which element should be rendered compacted/expanded in PHP, not JavaScript.

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 4, 2020
@ln-dim ln-dim force-pushed the issue_35800_improve_var_dumper_html_rendering branch from ea619df to db6e1cd Compare March 4, 2020 12:39
@ln-dim ln-dim changed the title [VarDumper] improve HTML rendering [WIP] [VarDumper] improve HTML rendering Mar 4, 2020
@ln-dim ln-dim force-pushed the issue_35800_improve_var_dumper_html_rendering branch 3 times, most recently from 7fdcb98 to 41f5195 Compare March 4, 2020 14:20
@ln-dim ln-dim changed the title [WIP] [VarDumper] improve HTML rendering [VarDumper] improve rendering HTML Mar 4, 2020
@ln-dim
Copy link
Contributor Author

ln-dim commented Mar 4, 2020

Travis CI jobs do not seem to work by accident. Not sure if I have to get them to pass.

nicolas-grekas
nicolas-grekas reviewed Apr 4, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me, just a few minor questions before approving my side.

@ln-dim ln-dim force-pushed the issue_35800_improve_var_dumper_html_rendering branch from 41f5195 to d93a978 Compare April 8, 2020 18:52
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@xabbuh xabbuh modified the milestones: 5.1, next May 5, 2020
@nicolas-grekas nicolas-grekas force-pushed the issue_35800_improve_var_dumper_html_rendering branch from d93a978 to 0a4ef89 Compare June 30, 2020 14:44
@nicolas-grekas
Copy link
Member

Thank you @ln-dim.

@nicolas-grekas nicolas-grekas merged commit 187b66b into symfony:master Jun 30, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 16, 2020
Closed
@rodrigopedra rodrigopedra mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@Kocal Kocal Kocal left review comments

Assignees
No one assigned
Labels
Status: Needs Review VarDumper
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[VarDumper] Improve rendering in HTML format
5 participants
@ln-dim @nicolas-grekas @Kocal @xabbuh @carsonbot