Skip to content

[FrameworkBundle][Routing] Add link to source to router:match #36144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

[FrameworkBundle][Routing] Add link to source to router:match #36144

merged 1 commit into from
Mar 20, 2020

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Mar 19, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets https://github.com/orgs/symfony/projects/1#card-30505860
License MIT
Doc PR

Add link to source on debug:router/router:match when framework.ide is configured

@nicolas-grekas nicolas-grekas added this to the next milestone Mar 19, 2020
nicolas-grekas
nicolas-grekas approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks

@l-vo l-vo force-pushed the add_link_to_source_router_match branch 2 times, most recently from 8c674f5 to dad19bb Compare March 19, 2020 20:30
@l-vo l-vo force-pushed the add_link_to_source_router_match branch from dad19bb to 83b307a Compare March 20, 2020 08:54
@l-vo
Copy link
Contributor Author

l-vo commented Mar 20, 2020

Added $this->formatValue to safely handle $defaults['_controller'] if not a string

@l-vo l-vo force-pushed the add_link_to_source_router_match branch from 83b307a to b9cbd3d Compare March 20, 2020 09:19
@l-vo l-vo force-pushed the add_link_to_source_router_match branch from b9cbd3d to a96690c Compare March 20, 2020 09:40
@fabpot
Copy link
Member

fabpot commented Mar 20, 2020

Thank you @l-vo.

@fabpot fabpot mentioned this pull request Mar 20, 2020
Closed
@fabpot fabpot merged commit 7e181b9 into symfony:master Mar 20, 2020
@l-vo l-vo deleted the add_link_to_source_router_match branch March 20, 2020 09:47
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Routing Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@l-vo @fabpot @nicolas-grekas @chalasr @carsonbot