Skip to content

[FrameworkBundle] Add file links to named controllers in debug:router #36270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2020
Merged

[FrameworkBundle] Add file links to named controllers in debug:router #36270

merged 1 commit into from
Apr 5, 2020

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Mar 30, 2020 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Before
Screenshot 2020-03-31 at 21 52 11

After
Screenshot 2020-03-31 at 21 51 11

@chalasr chalasr added this to the next milestone Mar 30, 2020
@chalasr chalasr force-pushed the ctrl-service-file-link branch from baf46f0 to 37e4e80 Compare March 30, 2020 16:27
nicolas-grekas
nicolas-grekas reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicking :)

@chalasr chalasr force-pushed the ctrl-service-file-link branch 2 times, most recently from c3e552b to 116d011 Compare March 31, 2020 19:56
@chalasr
Copy link
Member Author

chalasr commented Mar 31, 2020

Review addressed + Before/After added to the PR body. Thank you!

@chalasr chalasr force-pushed the ctrl-service-file-link branch from 116d011 to 10b5e94 Compare March 31, 2020 20:00
@chalasr chalasr force-pushed the ctrl-service-file-link branch from 10b5e94 to 932ae91 Compare April 1, 2020 15:47
@nicolas-grekas
Copy link
Member

Thank you @chalasr

@nicolas-grekas nicolas-grekas merged commit 5517fbc into symfony:master Apr 5, 2020
@chalasr chalasr deleted the ctrl-service-file-link branch April 5, 2020 16:41
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @nicolas-grekas @carsonbot