Skip to content

[FrameworkBundle] Deprecate flashbag and attributebag services #36273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

[FrameworkBundle] Deprecate flashbag and attributebag services #36273

merged 1 commit into from
Apr 1, 2020

Conversation

warslett
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? yes
Tickets Related to #10557
Related to PR #36063
License MIT

FlashBag and AttributeBag are data objects and so should not be available via the service container. The preferred method for accessing these objects is via
$session->getFlashBag() or $session->getAttributeBag()

@warslett warslett changed the title Deprecate flashbag and attributebag services [FrameworkBundle] Deprecate flashbag and attributebag services Mar 30, 2020
@warslett warslett force-pushed the deprecate-flashbag-and-attributebag-services branch from 63fef32 to 2e4bc95 Compare March 30, 2020 18:55
@warslett warslett mentioned this pull request Mar 30, 2020
Merged
@nicolas-grekas nicolas-grekas added this to the next milestone Mar 31, 2020
nicolas-grekas
nicolas-grekas reviewed Mar 31, 2020
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just minor comments on my side.

Tobion
Tobion reviewed Mar 31, 2020
View reviewed changes
@warslett warslett force-pushed the deprecate-flashbag-and-attributebag-services branch from f35df01 to 4baed97 Compare March 31, 2020 20:30
@warslett
Copy link
Contributor Author

rebased to resolve conflicts

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Mar 31, 2020 •
edited
Loading

Actually, please rebase again to account for #35778, thanks :)

@warslett
Copy link
Contributor Author

@nicolas-grekas rebased and now using new deprecated attributes. Nice feature @atailouloute

@fabpot
Copy link
Member

fabpot commented Apr 1, 2020

Thank you @warslett.

@fabpot fabpot force-pushed the deprecate-flashbag-and-attributebag-services branch from 298452a to f9b52fe Compare April 1, 2020 05:18
@fabpot fabpot mentioned this pull request Apr 1, 2020
Closed
@fabpot fabpot merged commit 09dcbfc into symfony:master Apr 1, 2020
@warslett warslett deleted the deprecate-flashbag-and-attributebag-services branch April 1, 2020 05:47
@warslett warslett mentioned this pull request Apr 1, 2020
Closed
@dannyvw dannyvw mentioned this pull request Apr 6, 2020
Merged
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@BackEndTea
Copy link
Contributor

I agree that this shouldn't be injected, however i'm running into an issue with this deprecation, namely:

The SessionInterface does not have the getFlashBag method that the Session does have. And the Session isnt' available for contsturcot injection, unlike the interface.

Maybe this method should be added to the interface?

@BackEndTea BackEndTea mentioned this pull request Jun 4, 2020
Closed
@michealmouner michealmouner mentioned this pull request Aug 31, 2020
Merged
@wouterj wouterj mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
Deprecation Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
6 participants
@warslett @nicolas-grekas @fabpot @BackEndTea @Tobion @carsonbot