Skip to content

[Validator] Add invalid datetime message in Range validator #36326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2020
Merged

[Validator] Add invalid datetime message in Range validator #36326

merged 1 commit into from
Sep 24, 2020

Conversation

przemyslaw-bogusz
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

When the validated value is invalid (it isn't a number nor a datetime), but min or max option indicate that the Range constraint is being used to validate a datetime, the displayed message will be This value should be a valid datetime instead of This value should be a valid number. This PR replaces #35998.

@przemyslaw-bogusz przemyslaw-bogusz mentioned this pull request Apr 2, 2020
Closed
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 3, 2020
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 16, 2020 •
edited
Loading

min or max option indicate that the Range

since this is using some heuristic logic, I would suggest reporting this when min AND max are can be parsed as dates.

@fabpot
Copy link
Member

fabpot commented Aug 12, 2020

@przemyslaw-bogusz Any comments about @nicolas-grekas suggestion?

@przemyslaw-bogusz
Copy link
Contributor Author

@nicolas-grekas I've modified the PR. As I understand, if one of the boundries is null and the other one is parsable DateTime string, this should also return invalidDateTimeMessage instead of invalidMessage?

fabpot
fabpot requested changes Sep 5, 2020
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased on master as this is a new feature.

@fabpot
Copy link
Member

fabpot commented Sep 19, 2020

@przemyslaw-bogusz I think you're right for your latest question. Still willing to finish this PR for master?

@przemyslaw-bogusz przemyslaw-bogusz changed the base branch from 3.4 to master September 20, 2020 20:21
@lyrixx lyrixx removed their request for review September 21, 2020 16:25
@fabpot fabpot force-pushed the range_invalid_message branch from 69792c2 to c777306 Compare September 24, 2020 14:49
@fabpot
Copy link
Member

fabpot commented Sep 24, 2020

Thank you @przemyslaw-bogusz.

@fabpot fabpot mentioned this pull request Sep 24, 2020
Closed
@fabpot fabpot merged commit 2bdcf4a into symfony:master Sep 24, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeahDude HeahDude HeahDude left review comments

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Reviewed Validator
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@przemyslaw-bogusz @nicolas-grekas @fabpot @HeahDude @carsonbot