Skip to content

Revert to container.dumper.inline_factories=false by default #36354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

Revert to container.dumper.inline_factories=false by default #36354

merged 1 commit into from
Apr 6, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

As spotted by @Tobion in #36193 (review)

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 6, 2020
@nicolas-grekas nicolas-grekas changed the title Revert container.dumper.inline_factories=false by default Revert to container.dumper.inline_factories=false by default Apr 6, 2020
@nicolas-grekas nicolas-grekas force-pushed the di-inline-factories-default branch from b6c7c35 to 2b6f1e9 Compare April 6, 2020 08:47
@fabpot
Copy link
Member

fabpot commented Apr 6, 2020

Thank you @nicolas-grekas.

@fabpot fabpot merged commit dadb5d8 into symfony:master Apr 6, 2020
@nicolas-grekas nicolas-grekas deleted the di-inline-factories-default branch April 6, 2020 13:07
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Tobion Tobion Tobion approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @Tobion @carsonbot