[Serializer] add UidNormalizer #36406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml
Outdated
Show resolved
Hide resolved
dunglas
requested changes
Apr 20, 2020
dunglas
reviewed
Apr 20, 2020
3e2abfb to
74235ab
Compare
5ff8932 to
abe7069
Compare
fabpot
requested changes
Aug 17, 2020
| @@ -18,6 +18,7 @@ CHANGELOG | |||
| * Made `BrowserKitAssertionsTrait` report the original error message in case of a failure | |||
| * Added ability for `config:dump-reference` and `debug:config` to dump and debug kernel container extension configuration. | |||
| * Deprecated `session.attribute_bag` service and `session.flash_bag` service. | |||
| * Added `UidNormalizer` to the framework serializer. | |||
| <service id="serializer.normalizer.uid" class="Symfony\Component\Serializer\Normalizer\UidNormalizer"> | ||
| <!-- Run before serializer.normalizer.object --> | ||
| <tag name="serializer.normalizer" priority="-880" /> | ||
| </service> |
There was a problem hiding this comment.
Should be moved to the new PHP config file.
For the priority, I would use -915 to be consistent with the other very specialized normalizers.
| @@ -8,6 +8,7 @@ CHANGELOG | |||
| * added support for `\stdClass` to `ObjectNormalizer` | |||
| * added the ability to ignore properties using metadata (e.g. `@Symfony\Component\Serializer\Annotation\Ignore`) | |||
| * added an option to serialize constraint violations payloads (e.g. severity) | |||
| * added `UidNormalizer` | |||
There was a problem hiding this comment.
Should be moved to the 5.2.0 section.
| */ | ||
| public function normalize($object, string $format = null, array $context = []) | ||
| { | ||
| if (!$object instanceof AbstractUid) { |
There was a problem hiding this comment.
The condition can be removed as the supports method garuantees that already.
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @throws InvalidArgumentException |
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @throws NotNormalizableValueException |
| */ | ||
| public function denormalize($data, string $type, string $format = null, array $context = []) | ||
| { | ||
| if (!class_exists(AbstractUid::class)) { |
| try { | ||
| $uid = Ulid::class === $type ? Ulid::fromString($data) : Uuid::fromString($data); | ||
| } catch (\InvalidArgumentException $exception) { | ||
| throw new NotNormalizableValueException('The data is not a valid '.$type.' string representation.'); |
|
@guillbdx Can you have a look at the feedback? |
3 tasks
|
Anyone willing to take over this PR? |
|
Closing in favor of #38151 |
fabpot
added a commit
that referenced
this pull request
Sep 11, 2020
This PR was merged into the 5.2-dev branch. Discussion ---------- [Serializer] add UidNormalizer | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | #36102 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> UUID and ULID normalizer. Continuation of #36406 Commits ------- d6a8993 Update based on feedback 1c21c78 UidNormalizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UUID and ULID normalizer.