[Ldap] Feature/force lowercase attributes #36432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 12, 2020 01:34
…e all lowercase, to reduce overall confusion and enforce a standard (if desired).
OskarStark
requested changes
Apr 13, 2020
| @@ -18,11 +18,16 @@ class Entry | |||
| { | |||
| private $dn; | |||
| private $attributes; | |||
| private $force_lowercase_attributes; | |||
There was a problem hiding this comment.
Variables should be named in camelCase
There was a problem hiding this comment.
Ok, I'll change it. I'm surprised the PSR tests didn't pick that up.
|
@elvis2 Any news? |
|
Closing as there is no more activity. Feel free to reopen when you have time. |
|
New PR: #39037 |
fabpot
added a commit
that referenced
this pull request
Nov 27, 2020
…(karlshea) This PR was merged into the 5.3-dev branch. Discussion ---------- [Ldap] Ldap Entry case-sensitive attribute key option | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A See PR #36432 Commits ------- d3b9440 [Ldap] Ldap Entry case-sensitive attribute key option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e all lowercase, to force case insensitivity and enforce a standard (if desired) for the consumer software.
Why? Companies have different AD setups, some force certain naming conventions, that developers may not know what and why. Coding around these pseudo standards introduces complex code that isn't necessary. Allowing the SE to force all lowercase attributes will ease their utilization of symfony/ldap and overall (I think) have better quality code.