[String] Add locale-sensitive map for slugging symbols #36456
Conversation
|
I modify the PR as i understand of your recommandations @nicolas-grekas ;) thank you for your feedbacks |
There was a problem hiding this comment.
Wow, I like this feature.
But what if the $locale is fr and I use the default $charsReplacement = ['en' => ['@' => 'at', '&' => 'and']]. Then nothing will be slugged, right?
Does it make sense to be more complex here? Maybe dedicate this replacement thing to a separate class?
There was a problem hiding this comment.
This should be a constructor argument, not a method argument. The argument should default to null and the default value be set on the property I think.
But what if the $locale is fr and I use the default $charsReplacement = ['en' => ['@' => 'at', '&' => 'and']]. Then nothing will be slugged, right?
Yes, that's the expected behavior to me.
Does it make sense to be more complex here? Maybe dedicate this replacement thing to a separate class?
Getting more complex is always possible by implementing SluggerInterface. Since the AsciiSlugger already does these simple mappings, I think it makes sense to make the map locale-aware (as the class already is).
|
There is still one question remaining here: how will people take advantage of the new argument in a Symfony app? How will they configure the map? Do we need tighter integration? |
|
@nicolas-grekas i have fixed your feedbacks, thank you for your reviews |
|
Thank you @lmasforne. |
Am I right that there is no way to configure the `$ymbolsMap` when using the Symfony framework integration (i.e. dependency injection)? What about adding a public method for this? The feature to set it in the constructor was added in symfony#36456
By default chars '@' and '&' are respectively replaced by 'at' and 'and' (so limited by enlgish language).
I had an $options arguments to 'slug' method to replace chars with your own logic.