Skip to content

[FrameworkBundle] remove getContainer overwrites in tests #36522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Apr 22, 2020

Q A
Branch? 5.0
Bug fix? no
New feature? no
Deprecations? no
Tickets
Doc PR

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see #31202

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202
@Tobion Tobion force-pushed the remove-get-container-overwrite branch from 7ecac97 to 5ef9390 Compare April 22, 2020 00:36
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Apr 22, 2020
@nicolas-grekas nicolas-grekas changed the title remove getContainer overwrites in tests [FrameworkBundle] remove getContainer overwrites in tests Apr 22, 2020
@nicolas-grekas
Copy link
Member

Thank you @Tobion.

@nicolas-grekas nicolas-grekas merged commit a2f0bf8 into symfony:5.0 Apr 22, 2020
@Tobion Tobion deleted the remove-get-container-overwrite branch April 22, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants