Skip to content

[PhpUnitBridge] fix compatibility with phpunit 9 #36539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

[PhpUnitBridge] fix compatibility with phpunit 9 #36539

merged 1 commit into from
Apr 24, 2020
+10 −3

Conversation

garak
Copy link
Contributor

@garak garak commented Apr 23, 2020

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36499
License MIT
Doc PR none

See related issue

@garak garak force-pushed the fix-phpunit-blacklist branch from a8dddc5 to 971e800 Compare April 23, 2020 08:05
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Apr 23, 2020
@nicolas-grekas
Copy link
Member

Looks like src/Symfony/Bridge/PhpUnit/bin/simple-phpunit also uses the blacklist.

@garak garak force-pushed the fix-phpunit-blacklist branch from 88400b3 to 811daab Compare April 23, 2020 08:57
@garak
Copy link
Contributor Author

garak commented Apr 23, 2020

Added check in simple-phpunit too

@garak garak force-pushed the fix-phpunit-blacklist branch from 67cdd07 to 3ad44bf Compare April 23, 2020 09:00
@garak garak force-pushed the fix-phpunit-blacklist branch from ffd0047 to 0ecae1e Compare April 23, 2020 12:29
@nicolas-grekas nicolas-grekas changed the title fix compatibility with phpunit 9 [PhpUnitBridge] fix compatibility with phpunit 9 Apr 23, 2020
@garak garak force-pushed the fix-phpunit-blacklist branch from 36213a5 to 3cc9aab Compare April 24, 2020 07:38
@garak garak force-pushed the fix-phpunit-blacklist branch from aa5b23e to e27ed28 Compare April 24, 2020 07:56
@fabpot
Copy link
Member

fabpot commented Apr 24, 2020

Thank you @garak.

@fabpot fabpot merged commit 719bb15 into symfony:3.4 Apr 24, 2020
@garak garak deleted the fix-phpunit-blacklist branch April 24, 2020 08:32
@Jean85 Jean85 mentioned this pull request Apr 24, 2020
Merged
fabpot added a commit that referenced this pull request Apr 25, 2020
@fabpot
minor #36568 [PhpUnitBridge] Improve dirname usage (Jean85)
b3cdf5c 
This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Improve dirname usage

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36499
| License       | MIT

This is a very small performance improvement on top of #36539

Commits
-------

e721cfd Improve dirname usage
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 27, 2020
Closed
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinssipenko martinssipenko martinssipenko left review comments

@localheinz localheinz localheinz left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
7 participants
@garak @nicolas-grekas @fabpot @martinssipenko @localheinz @Jean85 @carsonbot