Skip to content

[YAML] escape DEL(\x7f) #36560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

[YAML] escape DEL(\x7f) #36560

merged 1 commit into from
Apr 24, 2020

Conversation

sdkawata
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36559
License MIT
Doc PR none

@sdkawata sdkawata requested a review from xabbuh as a code owner April 24, 2020 08:44
@xabbuh
Copy link
Member

xabbuh commented Apr 24, 2020

Can you please add a test case?

@sdkawata sdkawata force-pushed the escape_del_when_dump_yaml branch from 48220bc to 37b17a3 Compare April 24, 2020 10:07
@sdkawata sdkawata force-pushed the escape_del_when_dump_yaml branch from 37b17a3 to 734d97b Compare April 24, 2020 10:22
@fabpot
Copy link
Member

fabpot commented Apr 24, 2020

Thank you @sdkawata.

@fabpot fabpot merged commit fe5eacd into symfony:3.4 Apr 24, 2020
This was referenced Apr 28, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdkawata @xabbuh @fabpot @carsonbot