[WebProfilerBundle] changed label of peak memory usage in the time & memory panels (MB into MiB) #36571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Apr 24, 2020
wouterj
approved these changes
Apr 24, 2020
chalasr
approved these changes
Apr 25, 2020
xabbuh
approved these changes
Apr 25, 2020
…memory panels (MB into MiB)
|
Thank you @Lozik. |
fabpot
added a commit
that referenced
this pull request
May 26, 2020
…e panel (Mb into MiB) (Lozik) This PR was merged into the 4.4 branch. Discussion ---------- [WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #36533 | License | MIT | Doc PR | - This PR fixes the memory usage labels in the time panel of the web profiler for 4.4+. PR #36571 already fixed this for 3.4 but since the time panel has been rewritten in 4.3, that minor fix has not correctly been transferred into 4.4+. Commits ------- a91204a [WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the label of the peak memory usage from
MBintoMiBin the time and memory panels of the web profiler, as discussed in #36533.The changed file
Resources/views/Collector/time.html.twigis completely updated by commit symfony/web-profiler-bundle@c9433b0 for v4.3. So for correctly displaying the label in 4.4 (& 5.0), the fileResources/views/Collector/time.jsneeds to be updated.